[READY] add token disable config/logic in the frontend#607
Merged
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces token disable configuration and logic in the frontend to control the availability of fiat tokens. Key changes include adding default token constants and updating stores, enhancing URL parameter processing and validation for token availability, and integrating token unavailability events in the events context.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/stores/rampDirectionStore.ts | Introduces a default ramp direction constant used in the store initialization. |
| frontend/src/stores/ramp/useRampFormStore.ts | Adds default fiat token constants and uses them in the initial store values. |
| frontend/src/hooks/useRampUrlParams.ts | Updates URL parameter handling to leverage token defaults and fiat token status. |
| frontend/src/hooks/ramp/useRampValidation.ts | Adds token availability validation with event tracking for disabled tokens. |
| frontend/src/contexts/events.tsx | Introduces a new TokenUnavailableErrorEvent interface in the events context. |
| frontend/src/config/tokenAvailability.ts | Provides a central configuration for fiat token availability and associated helpers. |
| frontend/src/components/Ramp/Onramp/index.tsx | Removes an unused hook import. |
| frontend/src/components/InputKeys/SelectionModal.tsx | Adds a check for disabled tokens when handling token selection. |
| frontend/src/components/InputKeys/PoolListItem/index.tsx | Updates the UI to visually indicate unavailable tokens with styling and messaging. |
Files not reviewed (2)
- frontend/src/translations/en.json: Language not supported
- frontend/src/translations/pt.json: Language not supported
ebma
reviewed
Apr 30, 2025
Member
ebma
left a comment
There was a problem hiding this comment.
Looks good overall. Thanks for the refactor 👍 We should fix that translation key though before merging.
| }, | ||
| "insufficientFunds": "Saldo insuficiente. Seu saldo é {{userInputTokenBalance}} {{assetSymbol}}", | ||
| "moreThanMaximumWithdrawal": { | ||
| "sell": "O valor máximo de compra é {{maxAmountUnits}} {{assetSymbol}}.", |
Member
There was a problem hiding this comment.
I think the problem here is not a duplicate but the same key name, ie both being called "sell". Please re-add the key and call it "buy" instead.
ebma
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.